In a couple of days ago, I've sent PM to him that talking about .39 patches. he had removed SPINLOCK at all... but I suggest like this in firegl_public.c line 1052:
dev->spinlock[i] = SPIN_LOCK_UNLOCKED;to
dev->spinlock[i] = __SPIN_LOCK_UNLOCKED(old_style_spin_init);I think that's better. but I agree he had purged lock/unlock_kernel as "big lock kernel". I also don't like these unstable locks... :) it would cause to be unstable for other kernelspace drivers like Wifi...